Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save calibration data and show preliminary GUI #1078

Merged
merged 57 commits into from
Jan 3, 2024

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Dec 28, 2023

Trimmed down version of #1062 without the graphs in the frontend

@mcm001 mcm001 marked this pull request as ready for review December 28, 2023 07:16
@mcm001 mcm001 requested a review from a team as a code owner December 28, 2023 07:16
@mcm001 mcm001 added this to the 2024 Kickkoff milestone Dec 29, 2023
Copy link
Member

@srimanachanta srimanachanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to have the TestMode files updated and build test needs to pass

@mcm001
Copy link
Contributor Author

mcm001 commented Jan 2, 2024

Rip lint

gerth2
gerth2 previously requested changes Jan 3, 2024
Copy link
Contributor

@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thought left

photon-lib/py/photonlibpy/calibrationUtils.py Outdated Show resolved Hide resolved
@srimanachanta srimanachanta dismissed gerth2’s stale review January 3, 2024 17:57

addressed review, moved to devTools folder in main repo as per discord

@srimanachanta srimanachanta merged commit 7f09f9e into PhotonVision:master Jan 3, 2024
23 checks passed
@mcm001 mcm001 deleted the 2023-12-27_save_cal_data branch January 3, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to import and export complete calibrations from a json file
4 participants